-
Notifications
You must be signed in to change notification settings - Fork 202
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable support for free-threading #1295
Draft
zsol
wants to merge
2
commits into
main
Choose a base branch
from
pr1295
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
won't
transform.context
get clobbered here:LibCST/libcst/codemod/_cli.py
Lines 264 to 271 in 985cec8
This is mostly safe with the GIL, so long as python doesn't switch to another thread that also owns a reference to
transform
, but in free-threading with the sort of parallel thread pool setup you have here it's much more likely to happen.In general - how do you want to go about adding multithreaded tests? It looks like there's a decent amount of stateful objects that get passed around and updated. How much should we worry about threads simultaneously updating stateful objects?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oh yeah absolutely - we'll probably have to change how state is passed around between threads. In fact, it might be better to just make a new transformer instance for each file and only pass immutable data structures between threads/processes.
We could run the test suite with something like
unittest-ft
, but the main thing I'd look for is the concurrent execution of the same set of visitors/transformers on multiple input files (basically what this PR sketches out), and then any bugs we find we can write targeted tests. How does that sound?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds great, that's more or less what I've been doing with
pyca/cryptography
this week: pyca/cryptography#12555Another thing I learned there is moving code form pure python to Rust can also be a way to avoid thread safety issues. If we move state from Python to Rust then we have much more control over concurrent multithreaded access.
I'll look at this next week - thanks for merging my other PR!