Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed constexpr significant bits value for double #1393

Merged
merged 1 commit into from
Sep 6, 2023
Merged

Fixed constexpr significant bits value for double #1393

merged 1 commit into from
Sep 6, 2023

Conversation

oleksandr-pavlyk
Copy link
Collaborator

@oleksandr-pavlyk oleksandr-pavlyk commented Sep 6, 2023 •
edited
Loading

Fixed constexpr significant bits value for double type.

Renamed variable for clarity.

This is commit is cherry-picked from gh-1383

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to an issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • If this PR is a work in progress, are you opening the PR as a draft?

@github-actions
Copy link

github-actions bot commented Sep 6, 2023

View rendered docs @ https://intelpython.github.io/dpctl/pulls/1393/index.html

@github-actions
Copy link

github-actions bot commented Sep 6, 2023

Array API standard conformance tests for dpctl=0.14.6dev4=py310ha25a700_50 ran successfully.
Passed: 916
Failed: 84
Skipped: 119

@oleksandr-pavlyk oleksandr-pavlyk merged commit a91fc55 into master Sep 6, 2023
24 of 25 checks passed
@oleksandr-pavlyk oleksandr-pavlyk deleted the fix-typo-in-sqrt branch September 6, 2023 19:59
@github-actions
Copy link

github-actions bot commented Sep 6, 2023

Deleted rendered PR docs from intelpython.github.com/dpctl, latest should be updated shortly. 🤞

@oleksandr-pavlyk oleksandr-pavlyk mentioned this pull request Sep 11, 2023
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ndgrigorian ndgrigorian ndgrigorian approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@oleksandr-pavlyk @ndgrigorian