Shakedown of field menu items

[rmkaplan]

This addresses field menu-item issues:
#1953
#1952
#1950
#1949

It now validates the IDENTIFIER, raising an error if it is not a string or non-NIL atom. And it uppercases, for consistency.

MB.ADD has an extra argument INCREMENTALUPDATES. If defaulted to NIL, the screen will not be updated at all until all the items are added. If T, the update will happen after each insertion, as before.

The last inserted items is not highlighted at the end of the MB.ADD, and the selection is disabled.

[rmkaplan]

I added a small change to to non-field menu items to suppress copy-selecting, cf #1297

[fghalasz]

@rmkaplan The first two arguments to the call to TEDIT.INSERT.OBJECT in the INITSTATE portion of MB.FIELD.CREATE are in the wrong order.

Also, from Notecards standpoint, uppercasing all IDENTIFIERS is not ideal. In the original code, Property Names are case sensitive. And I don't know which of the many Notecards extensions and applications depend on that case sensitivity. Currently I am using the Property Names as IDENTIFIERS, so if IDENTIFIERS are all U-CASEd I loose case sensitivity. My alternative is a relatively complicated mapping where I keep a permanent record of the Property Name to IDENTIFIER map.

[rmkaplan]

OK, I’ll fix the argument order. It’s unfortunate and confusing that the documented argument-orders for TEDIT.INSERT and TEDIT.INSERT.OBJECT are not the same. I'll take out the U-CASE (I guess I was trying to compensate for my own typos). Would a pop-up-menu button-type be useful? I haven’t tried the lfg scripts yet, waiting until I can get an ordinary full loadup to go through.

…

On Jan 9, 2025, at 12:59 AM, Frank Halasz ***@***.***> wrote: @rmkaplan <https://github.com/rmkaplan> The first two arguments to the call to TEDIT.INSERT.OBJECT in the INITSTATE portion of MB.FIELD.CREATE are in the wrong order. Also, from Notecards standpoint, uppercasing all IDENTIFIERS is not ideal. In the original code, Property Names are case sensitive. And I don't know which of the many Notecards extensions and applications depend on that case sensitivity. Currently I am using the Property Names as IDENTIFIERS, so if IDENTIFIERS are all U-CASEd I loose case sensitivity. My alternative is a relatively complicated mapping where I keep a permanent record of the Property Name to IDENTIFIER map. — Reply to this email directly, view it on GitHub <#1957 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AQSTUJN7G6XOVAQDQNNSOCL2JY3ABAVCNFSM6AAAAABUUONE72VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKNZZGQ4TONZQGQ>. You are receiving this because you were mentioned.

[fghalasz]

The TEdit Menu Fields are all working as expected in Notecards.