-
-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expand PSEUDOHOST as destination in FILECREATED info written #1979
Expand PSEUDOHOST as destination in FILECREATED info written #1979
Conversation
…sion. This will prevent some utility scripts from correct behavior. (E.g., restore-versions.sh looks for "{DSK}" to identify the file path and get the Medley file version number. This won't fix every case, for example if the PseudoHost is defined in terms of "{UNIX}", restore-versions.sh still wouldn't identify the file version.)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think we can resolve the problems of version numbers and files through a sequence of patches like this one, which doesn't address the fundamental problem that different people will have different version numbers in the file system than in the FILECREATED expressions.
The pseudohost part of the name in the filecreated expression is an approximation to a logical path name that in principle should abstract away from the full pathname that includes the location of the clone in the originator’s file system. The name should be good when the file is downloaded into a clone on another system.
But the filecreated version numbers are system-dependent, as noted, and my style of copying (as opposed to remaking) files from my working pseudohost {WMEDLEY} to my clone pseudohost {MEDLEY} also screws that up.
I’m not sure what kind of consistency guarantee we should or can provide between what is written in the FILECREATED expression (version, fullpath/pseudopath…) and the name/location of the file as it appears when downloaded to a new system.
… On Jan 20, 2025, at 9:00 PM, Larry Masinter ***@***.***> wrote:
@masinter commented on this pull request.
I don't think we can resolve the problems of version numbers and files through a sequence of patches like this one, which doesn't address the fundamental problem that different people will have different version numbers in the file system than in the FILECREATED expressions.
—
Reply to this email directly, view it on GitHub <#1979 (review)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AQSTUJIWI2TTBOWZPH4C6W32LXH6JAVCNFSM6AAAAABVRR6MSSVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDKNRTGQ3TSNZSGQ>.
You are receiving this because you are subscribed to this thread.
|
I agree that this is a stop gap solution so that |
What is the problem? Maybe we could work out some use cases? the main one I want to support is to ensure that if I make a new clone of the repo or remove all version files ( |
Per discussion 1/27, will not work as intended. Closed without merging. |
This change uses TRUEFILENAME to expand the FULLNAME of the output stream.
Some files are being saved with PseudoHosts in the FILECREATED expression. The PseudoHost will prevent some utility scripts from correct behavior.
(E.g., restore-versions.sh looks for "{DSK}" to identify the file path and get the Medley file version number. This won't fix every case, for example if the PseudoHost is defined in terms of "{UNIX}", restore-versions.sh still wouldn't identify the file version.)