Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Label some threads #31

Merged
merged 1 commit into from
Feb 4, 2025
Merged

Label some threads #31

merged 1 commit into from
Feb 4, 2025

Conversation

jasagredo
Copy link
Collaborator

No description provided.

@jasagredo jasagredo requested review from coot and bolt12 as code owners January 24, 2025 14:33
@jasagredo jasagredo mentioned this pull request Jan 24, 2025
Open
coot
coot approved these changes Jan 28, 2025
View reviewed changes
Copy link
Collaborator

@coot coot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, with a suggestion.

You'd like us to release the package to CHaP, isn't it?

src/System/Win32/Async/Socket.hs Outdated Show resolved Hide resolved
src/System/Win32/Async/Socket.hs Outdated Show resolved Hide resolved
@jasagredo
Copy link
Collaborator Author

A release to CHaP would be needed to integrate this into future versions of the node @coot

@jasagredo jasagredo merged commit ed2f531 into master Feb 4, 2025
11 checks passed
@jasagredo jasagredo deleted the js/label branch February 4, 2025 11:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@coot coot coot approved these changes

@bolt12 bolt12 Awaiting requested review from bolt12 bolt12 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jasagredo @coot