Change a representation of witnesses in transaction's certificates to an ordered map where a certificate is the key

[carbolymer]

Changelog

- description: |
    Change a representation of witnesses in transaction's certificates to an ordered map where a certificate is the key.
# uncomment types applicable to the change:
  type:
  # - feature        # introduces a new feature
   - breaking       # the API has changed in a breaking way
  # - compatible     # the API has changed but is non-breaking
  # - optimisation   # measurable performance improvements
  # - refactoring    # QoL changes
   - bugfix         # fixes a defect
  # - test           # fixes/modifies tests
  # - maintenance    # not directly related to the code
  # - release        # related to a new release preparation
  # - documentation  # change in code docs, haddocks...

Context

This PR changes representation of transaction certificates' witnesses from a list of with stake credentials to a map.

The issue is that there's a relationship Certificate *--1 StakeCredential which makes the assigning of witnesses impossible in the cases where we have more than one certificate with the same stake credential. This then breaks witnesses indexing.

See related PRs:

• Fix costs calculation for transaction with more than one certificates with the same stake credential and script witness cardano-cli#1028
• cardano-testnet | Create transaction with two script certificates test cardano-node#6082

Checklist

• Commit sequence broadly makes sense and commits have useful messages
• New tests are added if needed and existing tests are updated. See Running tests for more details
• Self-reviewed the diff

[Jimbo4350]

Confirm we aren't reintroducing a bug and I'll be happy to approve.

[Jimbo4350]

This makes my eyes bleed (I know it's not your fault).

[Jimbo4350]

I would seek confirmation that #456 is not an issue with this change. I suspect this needs to be a list still.

[carbolymer]

I suspect this needs to be a list still.

I don't see a reason for that.

I've ran regression tests here: https://github.com/IntersectMBO/cardano-node-tests/actions/runs/12928366127
cardano-testnet tests pass: IntersectMBO/cardano-node#6082

Is that enough?

[Jimbo4350]

Nice work. Takes a little while to page the context back into my head. One minor comment.

[Jimbo4350]

To be aware of.

In the ledger repo

-- For both of the functions `getScriptWitnessConwayTxCert` and
-- `getVKeyWitnessConwayTxCert` we preserve the old behavior of not requiring a witness
-- for staking credential registration, but only during the transitional period of Conway
-- era and only for staking credential registration certificates without a deposit. Future
-- eras will require a witness for registration certificates, because the one without a
-- deposit will be removed.

Eventually we should be able to remove the Maybe in:

OMap
        (Certificate era)
        ( BuildTxWith
            build
            (Maybe (StakeCredential, Witness WitCtxStake era))

Can you add a comment to the type definition pointing this out?

[carbolymer]

Added