Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove stylish haskell. Use only fourmolu for formatting. #1069

Merged
merged 3 commits into from
Feb 19, 2025

Conversation

carbolymer
Copy link
Contributor

Changelog

- description: |
    Remove stylish haskell. Use only fourmolu for formatting.
# uncomment types applicable to the change:
  type:
  # - feature        # introduces a new feature
  # - breaking       # the API has changed in a breaking way
  # - compatible     # the API has changed but is non-breaking
  # - optimisation   # measurable performance improvements
   - refactoring    # QoL changes
  # - bugfix         # fixes a defect
  # - test           # fixes/modifies tests
  # - maintenance    # not directly related to the code
  # - release        # related to a new release preparation
  # - documentation  # change in code docs, haddocks...

Context

Relevant api PR: IntersectMBO/cardano-api#756

This PR changes our formatting method to just use fourmolu instead of fourmolu + stylish-haskell. Import grouping settings were copied 1-1 from stylsh settings.

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated. See Running tests for more details
  • Self-reviewed the diff

@carbolymer carbolymer self-assigned this Feb 18, 2025
@carbolymer carbolymer force-pushed the mgalazyn/chore/remove-stylish-haskell branch from 5ea443d to 197f6f2 Compare February 18, 2025 15:08
@carbolymer carbolymer marked this pull request as ready for review February 18, 2025 15:32
@carbolymer carbolymer added this pull request to the merge queue Feb 19, 2025
Merged via the queue into master with commit 5330848 Feb 19, 2025
25 checks passed
@carbolymer carbolymer deleted the mgalazyn/chore/remove-stylish-haskell branch February 19, 2025 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants