Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add stake address registration and delegation certificate and stake pool delegation certificate to compatible commands #1070

Merged
merged 8 commits into from
Feb 28, 2025
Merged

Add stake address registration and delegation certificate and stake pool delegation certificate to compatible commands #1070

merged 8 commits into from
Feb 28, 2025

Conversation

carbolymer
Copy link
Contributor

@carbolymer carbolymer commented Feb 19, 2025 •
edited
Loading

Changelog

- description: |
    Add stake address registration and delegation certificate and stake pool delegation certificate to compatible commands
# uncomment types applicable to the change:
  type:
  # - feature        # introduces a new feature
  # - breaking       # the API has changed in a breaking way
   - compatible     # the API has changed but is non-breaking
  # - optimisation   # measurable performance improvements
  # - refactoring    # QoL changes
  # - bugfix         # fixes a defect
  # - test           # fixes/modifies tests
  # - maintenance    # not directly related to the code
  # - release        # related to a new release preparation
  # - documentation  # change in code docs, haddocks...

Context

Adds support for more compatible commands

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated. See Running tests for more details
  • Self-reviewed the diff

@carbolymer carbolymer changed the title wip Add more compatible commands Feb 19, 2025
@carbolymer carbolymer self-assigned this Feb 19, 2025
@carbolymer carbolymer force-pushed the mgalazyn/feature/add-more-compatible-commands branch from 2e3e4d7 to d1bc917 Compare February 19, 2025 19:17
@carbolymer carbolymer force-pushed the mgalazyn/feature/add-more-compatible-commands branch 2 times, most recently from 52daacd to 48414a5 Compare February 25, 2025 12:23
@carbolymer carbolymer force-pushed the mgalazyn/feature/add-more-compatible-commands branch 8 times, most recently from 859a1fe to 107da6c Compare February 26, 2025 07:46
@carbolymer carbolymer changed the title Add more compatible commands Add stake address registration and delegation certificate and stake pool delegation certificate to compatible commands Feb 26, 2025
@carbolymer carbolymer marked this pull request as ready for review February 26, 2025 07:46
Jimbo4350
Jimbo4350 requested changes Feb 26, 2025
View reviewed changes
Copy link
Contributor

@Jimbo4350 Jimbo4350 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please break this up into sensible commits

@carbolymer carbolymer force-pushed the mgalazyn/feature/add-more-compatible-commands branch from 107da6c to 9480b1c Compare February 27, 2025 12:35
@carbolymer carbolymer requested a review from Jimbo4350 February 27, 2025 12:37
Jimbo4350
Jimbo4350 approved these changes Feb 27, 2025
View reviewed changes
Copy link
Contributor

@Jimbo4350 Jimbo4350 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work 👍 . The commits you split the PR into made reviewing your changes much easier. There are a couple of comments, the one regarding catching exceptions should be addressed but I won't block the PR on this.

cardano-cli/src/Cardano/CLI/Compatible/Exception.hs

fromEitherCli :: (HasCallStack, MonadIO m, Show e, Typeable e, Error e) => Either e a -> m a
fromEitherCli = withFrozenCallStack $ \case
Left e -> throwCliError $ CustomCliException e
Left e -> throwCliError e
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

cardano-cli/src/Cardano/CLI/Compatible/StakeAddress/Run.hs Outdated

let regCert = makeStakeAddressRegistrationCertificate req

fromEitherIOCli @_ @(FileError ()) $
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting. We are prevented from specifying @(CIO e) because it is a type synonym. However @(RIO e) works.

@carbolymer carbolymer force-pushed the mgalazyn/feature/add-more-compatible-commands branch from 9480b1c to e12b559 Compare February 28, 2025 12:37
@carbolymer carbolymer force-pushed the mgalazyn/feature/add-more-compatible-commands branch 2 times, most recently from f9c1723 to 6a42e13 Compare February 28, 2025 12:40
@carbolymer carbolymer enabled auto-merge February 28, 2025 12:40
@carbolymer carbolymer disabled auto-merge February 28, 2025 12:44
@carbolymer carbolymer force-pushed the mgalazyn/feature/add-more-compatible-commands branch from 6a42e13 to a78730c Compare February 28, 2025 12:53
@carbolymer carbolymer enabled auto-merge February 28, 2025 12:53
@carbolymer carbolymer added this pull request to the merge queue Feb 28, 2025
Merged via the queue into master with commit ca174fe Feb 28, 2025
25 checks passed
@carbolymer carbolymer deleted the mgalazyn/feature/add-more-compatible-commands branch February 28, 2025 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jimbo4350 Jimbo4350 Jimbo4350 approved these changes

@newhoggy newhoggy Awaiting requested review from newhoggy newhoggy is a code owner

@smelc smelc Awaiting requested review from smelc smelc is a code owner

@palas palas Awaiting requested review from palas palas is a code owner

@kevinhammond kevinhammond Awaiting requested review from kevinhammond kevinhammond is a code owner

@disassembler disassembler Awaiting requested review from disassembler disassembler is a code owner

Assignees

@carbolymer carbolymer

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@carbolymer @Jimbo4350