Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate 10.3 Consensus queries #1081

Open
wants to merge 4 commits into
base: aniketd/release-10-3
Choose a base branch
from

Conversation

jasagredo
Copy link
Contributor

Changelog

- description: |
    <insert-changelog-description-here>
# uncomment types applicable to the change:
  type:
  # - feature        # introduces a new feature
  # - breaking       # the API has changed in a breaking way
  # - compatible     # the API has changed but is non-breaking
  # - optimisation   # measurable performance improvements
  # - refactoring    # QoL changes
  # - bugfix         # fixes a defect
  # - test           # fixes/modifies tests
  # - maintenance    # not directly related to the code
  # - release        # related to a new release preparation
  # - documentation  # change in code docs, haddocks...

Context

Additional context for the PR goes here. If the PR fixes a particular issue please provide a link to the issue.

How to trust this PR

Highlight important bits of the PR that will make the review faster. If there are commands the reviewer can run to observe the new behavior, describe them.

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated. See Running tests for more details
  • Self-reviewed the diff

@smelc
Copy link
Contributor

smelc commented Mar 6, 2025

@jasagredo> you need to recreate the golden files, to check the changes to the --help files as follows:

RECREATE_GOLDEN_FILES=1 cabal test cardano-cli-golden

and then commit the changes, after verifying them.

@smelc
Copy link
Contributor

smelc commented Mar 6, 2025

Other than that LGTM so far 👍

@jasagredo jasagredo marked this pull request as ready for review March 7, 2025 10:57
@smelc
Copy link
Contributor

smelc commented Mar 7, 2025

@jasagredo> I updated the golden files.

There are changes to the golden files of create-cardano, because you changed a parser that was used by it. Is that intended?

@jasagredo
Copy link
Contributor Author

Did I do so in my branch? I'm based off Aniket's release branch so maybe it was modified there?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants