Add CBOR instances for DefaultVote #4860
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I don't know exactly how you like to define CBOR instances. If the structure shall be different, do tell me. |
jasagredo
force-pushed
the
js/cbor-defaultvote
branch
from
8e37f79 to
a1b5663
Compare
aniketd
previously requested changes
Jan 29, 2025
jasagredo
force-pushed
the
js/cbor-defaultvote
branch
from
a1b5663 to
5093b24
Compare
lehins
reviewed
Jan 29, 2025
lehins
reviewed
Jan 29, 2025
lehins
reviewed
Jan 29, 2025
jasagredo
force-pushed
the
js/cbor-defaultvote
branch
from
5093b24 to
e59a601
Compare
|
I used |
lehins
force-pushed
the
js/cbor-defaultvote
branch
from
e59a601 to
79a1b99
Compare
|
I think @aniketd has to dismiss his request for changes in order to merge this |
teodanciu
dismissed
aniketd’s stale review
Comments are addressed, dismissing in order to unblock merging.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is necessary for IntersectMBO/ouroboros-consensus#1371
Checklist
Tests added or updated when neededCHANGELOG.mdfiles updated for packages with externally visible changesNew section is never added with the code changes. (See RELEASING.md)
Versions updated in.cabalandCHANGELOG.mdfiles when necessary, according to theversioning process.
Version bounds in
.cabalfiles updated when necessaryIf you change the bounds in a cabal file, that package itself must have a version increase. (See RELEASING.md)
scripts/fourmolize.sh)scripts/cabal-format.sh)hie.yamlupdated (usescripts/gen-hie.sh)