Update gitignore; cabal.project; aeson-pretty version bounds #65
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`aeson-pretty`'s Config datatype was updated in 0.8.5 to have a 4th field. This wasn't captured in the cabal file and I ran into a build error in a downstream package when an older version of `aeson-pretty` was built which lacked the 4th field. I also add /test to the `cabal.project` and gitignore the GHC env file.
|
We might also consider adding a CI check to ensure that |
Yup this would be a good idea. Opened issue: #66 |
|
bors r+ |
iohk-bors bot
added a commit
that referenced
this pull request
Sep 12, 2019
65: Update gitignore; cabal.project; aeson-pretty version bounds r=mhuesch a=mhuesch `aeson-pretty`'s Config datatype was updated in 0.8.5 to have a 4th field. This wasn't captured in the cabal file and I ran into a build error in a downstream package when an older version of `aeson-pretty` was built which lacked the 4th field. I also add /test to the `cabal.project` and gitignore the GHC env file. Co-authored-by: Michael Hueschen <[email protected]>
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
aeson-pretty's Config datatype was updated in 0.8.5 to have a 4thfield. This wasn't captured in the cabal file and I ran into a build
error in a downstream package when an older version of
aeson-prettywas built which lacked the 4th field.
I also add /test to the
cabal.projectand gitignore the GHC env file.