Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(sync_tests): improve node start/stop logic #51

Merged
merged 1 commit into from
Jan 30, 2025

Conversation

mkoura
Copy link
Collaborator

@mkoura mkoura commented Jan 30, 2025

  • Refactored start_node to return process and logfile
  • Updated stop_node to handle process termination and exit code
  • Improved error handling and logging in main function

- Refactored `start_node` to return process and logfile
- Updated `stop_node` to handle process termination and exit code
- Improved error handling and logging in `main` function
@mkoura mkoura requested a review from saratomaz January 30, 2025 10:40
@saratomaz saratomaz merged commit 7d92411 into main Jan 30, 2025
1 of 3 checks passed
@saratomaz saratomaz deleted the get_exit_codes branch January 30, 2025 10:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants