Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify isUnregisteredDRep #684

Merged
merged 3 commits into from
Feb 19, 2025
Merged

Conversation

carlostome
Copy link
Contributor

Description

Small refactor to replace a partially negated predicate in a negated position by an implication.

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • Any semantic changes to the specifications are documented in CHANGELOG.md
  • Code is formatted according to CONTRIBUTING.md
  • Self-reviewed the diff

Copy link
Collaborator

@WhatisRT WhatisRT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this, but it recently came up that using implication as in if can be quite confusing to newcomers (this was in the context of feesOK). Maybe it's not so confusing here, I don't know, but it's probably safer to just match on r anyway.

@WhatisRT WhatisRT force-pushed the carlos/refactor-isUnregisteredDRep branch from eab463f to df0667e Compare February 18, 2025 16:19
@carlostome carlostome requested review from WhatisRT and removed request for williamdemeo February 19, 2025 10:38
@WhatisRT WhatisRT merged commit 038817e into master Feb 19, 2025
8 checks passed
@WhatisRT WhatisRT deleted the carlos/refactor-isUnregisteredDRep branch February 19, 2025 11:20
github-actions bot added a commit that referenced this pull request Feb 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants