Refactor GOV from conformance #688
Open
+168
−469
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carlostome
force-pushed
the
carlos/refactor-gov-conformance
branch
3 times, most recently
from
88d13eb to
235bdaf
Compare
carlostome
force-pushed
the
carlos/refactor-gov-conformance
branch
from
cd255b3 to
244bc92
Compare
carlostome
force-pushed
the
carlos/refactor-gov-conformance
branch
from
5943b7b to
5ecd7ea
Compare
carlostome
force-pushed
the
carlos/refactor-gov-conformance
branch
from
f42bd3d to
d822d14
Compare
WhatisRT
approved these changes
Feb 20, 2025
| _⊢_⇀⦇_,GOV⦈_ = ReflexiveTransitiveClosureᵢ {sts = _⊢_⇀⦇_,GOV'⦈_} | ||
| _⊢_⇀⦇_,GOV⦈_ : GovEnv → GovState → List (GovVote ⊎ GovProposal) → GovState → Type | ||
| Γ ⊢ govSt ⇀⦇ gvps ,GOV⦈ govSt' | ||
| = ⟦ txid , epoch , pparams , ppolicy , enactState , conv certState , rewardCreds ⟧ L.⊢ govSt |ᵒ conv certState ⇀⦇ gvps ,GOV⦈ govSt' |
There was a problem hiding this comment.
What's the reason you moved |ᵒ here from LEDGER?
There was a problem hiding this comment.
If we called |ᵒ in Ledger then we would have to expose the conversion function as well. In this way, I think is more modular.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently the GOV rules in Conformance are analogous (modulo
CertState) to those in Ledger.This PR aims to remove the redundancy.
This PR consists of two commits:
Equivalence.Basewhere needed. This serves to break cyclic dependencies which occur in the next commit.Ledger.Conway.Conformance.Govas an interface forLedger.Gov.TBD
Checklist
CHANGELOG.md