-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[1976] New description for direct voter registration #2005
[1976] New description for direct voter registration #2005
Conversation
✅ All checks succeeded |
❌ Docker Image Scan (Dockle) failed No output |
Thoughts @HeptaSean @disassembler and Johnny |
✅ All checks succeeded |
Yes, like it. Maybe worth a mention that direct voters can, of course, delegate their other wallets and accounts to the “direct voter” dRep (and that makes a lot of sense, since they surely don't want to pay the deposit multiple times). |
As mentioned in #2001 (comment), I would still question the “direct voter” wording more fundamentally and maybe use “dRep with/without public information” and/or “(not) publically listed dRep” instead, but that should probably be discussed with more people and more time. So, please do this first. It already makes it much better. |
Just realised that that is not possible in gov.tools since you cannot give an arbitrary dRep ID to delegate to, but only choose from the list of (public) dReps. It is possible with Eternl and, of course, with CLI. So, that would also have to be in the text if you decide to add it. Since it really makes a lot of sense that “direct voters” only use one dRep for all of their wallets and accounts, delegation to arbitrary dRep IDs should probably become a feature request (for the non-Eternl/CLI users). |
Yup lets discuss the naming via #2012
Do you think this is a big use case? CC @m-i-k-e |
govtool/frontend/src/components/organisms/DashboardCards/DirectVoterDashboardCard.tsx
Outdated
Show resolved
Hide resolved
✅ All checks succeeded |
❌ Docker Image Scan (Dockle) failed No output |
✅ All checks succeeded |
1 similar comment
✅ All checks succeeded |
❌ Docker Image Scan (Dockle) failed No output |
✅ All checks succeeded |
Also @jdyczka why are the actions failing? not just related to this PR |
❌ Docker Image Scan (Dockle) failed No output |
✅ All checks succeeded |
✅ All checks succeeded |
govtool/frontend/src/components/organisms/DashboardCards/DirectVoterDashboardCard.tsx
Outdated
Show resolved
Hide resolved
3c4b74d
to
8ec72a3
Compare
8ec72a3
to
0e3eeda
Compare
✅ All checks succeeded |
2 similar comments
✅ All checks succeeded |
✅ All checks succeeded |
List of changes
Checklist