[1976] New description for direct voter registration

[Ryun1]

List of changes

• Change the direct voter registration message;
  • fix incorrect deposit info
  • generally improve clarity and distinction from DReps

Checklist

• related issue
• My changes generate no new warnings
• My code follows the style guidelines of this project
• I have commented my code, particularly in hard-to-understand areas
• I have made corresponding changes to the changelog
• I have added tests that prove my fix is effective or that my feature works

[github-actions]

✅ All checks succeeded

[github-actions]

❌ Docker Image Scan (Dockle) failed

No output

[Ryun1]

Thoughts @HeptaSean @disassembler and Johnny

[github-actions]

✅ All checks succeeded

[HeptaSean]

Thoughts @HeptaSean @disassembler and Johnny

Yes, like it. Maybe worth a mention that direct voters can, of course, delegate their other wallets and accounts to the “direct voter” dRep (and that makes a lot of sense, since they surely don't want to pay the deposit multiple times).

Also solves #1999 (that was mine) and #1976.

[HeptaSean]

As mentioned in #2001 (comment), I would still question the “direct voter” wording more fundamentally and maybe use “dRep with/without public information” and/or “(not) publically listed dRep” instead, but that should probably be discussed with more people and more time.

So, please do this first. It already makes it much better.

[HeptaSean]

Maybe worth a mention that direct voters can, of course, delegate their other wallets and accounts to the “direct voter” dRep

Just realised that that is not possible in gov.tools since you cannot give an arbitrary dRep ID to delegate to, but only choose from the list of (public) dReps. It is possible with Eternl and, of course, with CLI. So, that would also have to be in the text if you decide to add it.

Since it really makes a lot of sense that “direct voters” only use one dRep for all of their wallets and accounts, delegation to arbitrary dRep IDs should probably become a feature request (for the non-Eternl/CLI users).

[Ryun1]

As mentioned in #2001 (comment), I would still question the “direct voter” wording more fundamentally and maybe use “dRep with/without public information” and/or “(not) publically listed dRep” instead, but that should probably be discussed with more people and more time.

Yup lets discuss the naming via #2012

Since it really makes a lot of sense that “direct voters” only use one dRep for all of their wallets and accounts, delegation to arbitrary dRep IDs should probably become a feature request (for the non-Eternl/CLI users).

Do you think this is a big use case?
We can look at supporting it properly

CC @m-i-k-e

[github-actions]

✅ All checks succeeded

[github-actions]

❌ Docker Image Scan (Dockle) failed

No output

[github-actions]

✅ All checks succeeded

[github-actions]

✅ All checks succeeded

[github-actions]

❌ Docker Image Scan (Dockle) failed

No output

[github-actions]

✅ All checks succeeded

approved too soon

[Ryun1]

Also @jdyczka why are the actions failing? not just related to this PR

[github-actions]

❌ Docker Image Scan (Dockle) failed

No output

[github-actions]

✅ All checks succeeded

[github-actions]

✅ All checks succeeded

[github-actions]

✅ All checks succeeded

[github-actions]

✅ All checks succeeded

[github-actions]

✅ All checks succeeded