Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support network, add more host URLs, and set default tests to preview.gov.tools #2805

Merged
merged 5 commits into from
Jan 30, 2025
Merged

Support network, add more host URLs, and set default tests to preview.gov.tools #2805

merged 5 commits into from
Jan 30, 2025

Conversation

kneerose
Copy link
Contributor

List of changes

  • Add network on manual trigger for both frontend and backend
  • set default deployment to preview.gov.tools on both frontend and backend
  • Add mainnet, dev, preview host on backend

Checklist

  • related issue
  • My changes generate no new warnings
  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the changelog
  • I have added tests that prove my fix is effective or that my feature works

@kneerose kneerose requested a review from mesudip January 29, 2025 01:22
@github-actions GitHub Actions
Copy link

✅ All checks succeeded

2 similar comments
@github-actions GitHub Actions
Copy link

✅ All checks succeeded

@github-actions GitHub Actions
Copy link

✅ All checks succeeded

@kneerose kneerose mentioned this pull request Jan 29, 2025
Open
@kneerose kneerose merged commit 844ce38 into develop Jan 30, 2025
4 of 6 checks passed
@kneerose kneerose deleted the feat/support-network-on-manual-trigger branch January 30, 2025 02:27
@github-actions GitHub Actions
Copy link

@kneerose
This PR is in the tag: develop-844ce38b5daffb2e8d5147c2af26112338d41677 , for govtool-frontend service

@github-actions GitHub Actions
Copy link

@kneerose
This PR is in the tag: develop-844ce38b5daffb2e8d5147c2af26112338d41677 , for govtool-metadata-validation service

@github-actions GitHub Actions
Copy link

@kneerose
This PR is in the tag: develop-844ce38b5daffb2e8d5147c2af26112338d41677 , for govtool-backend service

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MSzalowski MSzalowski MSzalowski approved these changes

@placek placek placek approved these changes

@Ryun1 Ryun1 Awaiting requested review from Ryun1 Ryun1 is a code owner

@mesudip mesudip Awaiting requested review from mesudip

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kneerose @placek @MSzalowski