Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new GetLedgerConfig query #1394

Merged
merged 7 commits into from
Mar 5, 2025

Conversation

jasagredo
Copy link
Contributor

@jasagredo jasagredo commented Feb 17, 2025

Description

This is a revamp of #490 which in turn was a revamp of IntersectMBO/ouroboros-network#3214. The description is still the same:

Key changes:

  • Add GetLedgerConfig :: Query blk (LedgerConfig blk)
  • Make SerialiseNodeToClient blk (LedgerConfig blk) a superclass of SerialiseNodeToClientConstraints
    • This makes sense now that the Node-to-Client protocol includes a GetLedgerConfig query.
  • Add CBOR serialization instances for ledger configs and nested types.

@jasagredo jasagredo force-pushed the js/query-ledger-config branch from 0ab9401 to 822c784 Compare February 19, 2025 10:41
@jasagredo jasagredo changed the base branch from main to js/byron-hfc February 19, 2025 10:41
@jasagredo jasagredo force-pushed the js/query-ledger-config branch 6 times, most recently from f42ac55 to c88886b Compare February 19, 2025 13:59
@jasagredo jasagredo changed the title WIP Js/query ledger config Add new GetLedgerConfig query Feb 19, 2025
@jasagredo jasagredo marked this pull request as ready for review February 19, 2025 14:01
@jasagredo jasagredo force-pushed the js/query-ledger-config branch from c88886b to 7557892 Compare February 19, 2025 14:03
@jasagredo jasagredo force-pushed the js/query-ledger-config branch from 7557892 to 0f3d678 Compare February 20, 2025 15:29
@jasagredo jasagredo self-assigned this Feb 24, 2025
github-merge-queue bot pushed a commit that referenced this pull request Mar 3, 2025
# Description

I think this reorganization is useful. As a side note, I did it too in
#1394.
Base automatically changed from js/byron-hfc to main March 3, 2025 10:03
@jasagredo jasagredo force-pushed the js/query-ledger-config branch from 0f3d678 to 7b889ed Compare March 4, 2025 15:28
@jasagredo jasagredo changed the base branch from main to js/sts March 4, 2025 15:37
@jasagredo jasagredo force-pushed the js/query-ledger-config branch from 58e1631 to d571eb3 Compare March 4, 2025 16:36
Base automatically changed from js/sts to js/coot/aniketd/release-10-3 March 5, 2025 10:08
@jasagredo jasagredo force-pushed the js/query-ledger-config branch from d571eb3 to cc243e1 Compare March 5, 2025 10:10
@jasagredo jasagredo merged commit 1e2c0fe into js/coot/aniketd/release-10-3 Mar 5, 2025
2 checks passed
@jasagredo jasagredo deleted the js/query-ledger-config branch March 5, 2025 10:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

3 participants