A more precise type for Nary.inject #1399
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nfrisby
requested review from
jasagredo,
amesgen,
fraser-iohk,
dnadales and
geo2a
as code owners
amesgen
approved these changes
Feb 19, 2025
...oros-consensus/src/ouroboros-consensus/Ouroboros/Consensus/HardFork/Combinator/Embed/Nary.hs
Show resolved
Hide resolved
ouroboros-consensus/changelog.d/20250219_054827_nick.frisby_simplify_inject.md
Show resolved
Hide resolved
nfrisby
force-pushed
the
nfrisby/simplify-inject
branch
from
121ea51 to
29328d5
Compare
|
I rebased because I had forgot to sign some commits. |
The new type no longer requires the caller to specify when eras _after_ their given `Index` begin. This interface makes it obvious that the `Inject` logic does not depend on such `Bound`s.
nfrisby
force-pushed
the
nfrisby/simplify-inject
branch
from
29328d5 to
9db14f8
Compare
|
And again because I forgot to squash the commit that fixed the warning CI caught |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See the commit message of
consensus: a more precise type for Nary.inject; the other commits are superficial.