Fix build with GHC 9.4 #954
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amesgen
approved these changes
Feb 16, 2024
There was a problem hiding this comment.
Thanks! We don't test with GHC 9.4 on CI (only with 9.6 and, for legacy reasons, 8.10), so we can't guarantee that 9.4 will continue to work, but simple changes like this that are increasing compatibility sound fine 👍
Can you push again (without any changes) such that the changelog check is re-triggered?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adjusted the preprocessor directive to include GHC 9.4 and fixed a typo.