Refactor FirstToFinish and LastToFinish instances #3850
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deriving a semigroup instance via 'Alt' for 'IO' relies on 'IO' 'Alternative' instance, which is not what we want. We want 'race` semantics instead. The drawback is that one needs to specify the 'Semigroup (FirstToFinish m a)' constraint, when 'm' is abstract, as in the tests.
coot
commented
Jun 27, 2023
| deriving Foldable via (Alt m) | ||
| deriving Contravariant via (Alt m) | ||
|
|
||
|
|
||
| instance Semigroup (FirstToFinish IO a) where | ||
| FirstToFinish a <> FirstToFinish b = FirstToFinish $ either id id <$> race a b |
There was a problem hiding this comment.
We can use similar approach to LastToFinish.
coot
commented
Jun 27, 2023
| @@ -203,6 +204,8 @@ runMux :: forall m mode. | |||
| , MonadTime m | |||
| , MonadTimer m | |||
| , MonadMask m | |||
| , forall a stm. stm ~ STM m => Semigroup (FirstToFinish stm a) | |||
There was a problem hiding this comment.
Use a type alias for this constraint if possible.
bolt12
reviewed
Oct 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.