Let the thread which fetched a TX add it to the mempool #4984
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add the time it took to add TXs to the mempool to the TxInboundAddedToMempool tracer.
DeltaQ metrics is only available for our warm and hot peers that also have us as hot. So a fraction of all downstream clients will have a metric. This change the ranking of peers to use simple scoring system. Deliver a new TX before in time before it gets into the block gives you one point. Delivering a TXs thats already in the mempool, is invalid, or fail because it was included in a recent blocks gives you a penalty.
karknu
force-pushed
the
karknu/bolt12/coot/tx-submission
branch
from
4a99a6e
to
a3de87b
Compare
coot
reviewed
Oct 11, 2024
| let !accepted = length txidsAccepted | ||
|
|
||
| traceWith tracer $ TraceTxSubmissionProcessed ProcessedTxCount { | ||
| ptxcAccepted = accepted | ||
| , ptxcRejected = collected - accepted | ||
| , ptxcScore = 0 -- This implementatin does not track score |
Comment on lines
243
to
247
| cntRejects :: SharedTxState peeraddr txid tx | ||
| -> SharedTxState peeraddr txid tx | ||
| cntRejects st@SharedTxState { peerTxStates } = | ||
| let peerTxStates' = Map.update (\ps -> Just $! ps { rejectedTxs = min 42 (max (-42) (rejectedTxs ps + n)) }) peeraddr peerTxStates in | ||
| st {peerTxStates = peerTxStates'} |
There was a problem hiding this comment.
It will be more efficient to update it for all peers at once, but it might be harder to implement it. Another way would be to store the counts in Map peerAddt (TVar ...), so that we don't block on taking the whole state to update the count just for one peer.
| let receivedL = [ (txId tx, tx) | tx <- txs ] | ||
| fetchedSet <- consumeFetchedTxs (Set.fromList (map fst receivedL)) | ||
|
|
||
| -- Only attempt to add TXs if we actually has fetched some. |
There was a problem hiding this comment.
Suggested change
| -- Only attempt to add TXs if we actually has fetched some. | |
| -- Only attempt to add TXs if we actually have fetched some. |
Comment on lines
+95
to
+97
| -- Note that checking if the mempool contains a TX before | ||
| -- spending several ms attempting to add it to the pool has | ||
| -- been judged immoral. |
coot
changed the title
Use hashWithSalt to breaks ties when ranking peers with equal score. Track rejections in a bucket that slowly drains over time.
Bind responder threads to the lower cores, reserving the higest two cores for other tasks (block adoption, draining mempool etc.).
Make demos and framework sim-tests compile.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Previously all peers that had the TXid of a downloaded TX would attempt to add it to the mempool (a rather costly operation).
This patch moves the addition to the mempool to the Server's CollectTxs state. Which means that the downloaded TXs is only added by the thread that actually downloaded it.
The legacy TX submission protocol has been left as is.
Checklist
Quality
Maintenance
ouroboros-networkproject.