Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add NodeToClientV_20 #5055

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Add NodeToClientV_20 #5055

wants to merge 2 commits into from

Conversation

jasagredo
Copy link
Contributor

Description

Needed for the new query QueryStakePoolDefaultVote IntersectMBO/ouroboros-consensus#1371

Checklist

Quality

  • Commit sequence makes sense and have useful messages, see ref.
  • New tests are added and existing tests are updated.
  • Self-reviewed the PR.

Maintenance

  • Linked an issue or added the PR to the current sprint of ouroboros-network project.
  • Added labels.
  • Updated changelog files.
  • The documentation has been properly updated, see ref.

@jasagredo jasagredo requested a review from a team as a code owner January 29, 2025 10:32
@jasagredo jasagredo mentioned this pull request Jan 29, 2025
Open
@crocodile-dentist
Copy link
Contributor

There's a few other spots needing changes, see #4960

crocodile-dentist
crocodile-dentist approved these changes Jan 29, 2025
View reviewed changes
Copy link
Contributor

@crocodile-dentist crocodile-dentist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jasagredo jasagredo enabled auto-merge January 29, 2025 11:05
coot
coot approved these changes Jan 29, 2025
View reviewed changes
Copy link
Contributor

@coot coot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@crocodile-dentist crocodile-dentist added this pull request to the merge queue Jan 30, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jan 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@crocodile-dentist crocodile-dentist crocodile-dentist approved these changes

@coot coot coot approved these changes

Assignees
No one assigned
Labels
None yet
Projects
Ouroboros Network
Status: In Progress
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jasagredo @crocodile-dentist @coot