Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Finish yield bridge #1

Merged
merged 62 commits into from
Jul 2, 2024
Merged

Finish yield bridge #1

merged 62 commits into from
Jul 2, 2024

Conversation

knoll3
Copy link
Collaborator

@knoll3 knoll3 commented Jun 20, 2024

Yield Bridge

image

Major accomplishments

  • Added the net apy chart on the bridge page
  • Added the positions table on the bridge page

FIgma

https://www.figma.com/design/UbEsSn0vJrzzjdyldy3WAH/Ion-Protocol?node-id=10211-165942&t=t3q48yCx90SERO3t-0

Notes

Implements the yield bridge according to the Figma designs. There are still a number of things to add, like the APY and utilization rate calculations on the positions table which requires multiple api and contract calls. There are also a number of minor things to add:

  • Finish nav drawer, adding docs, discord, and terms links
  • Add user balance to the bridge input
  • Add icons to positions table
  • Replace lorem ipsum text
  • Make sure tooltips have consistent styling
  • Populate all tooltips
  • Handle case where chart only has 1 or 2 points but more than 0

Expect the chart on the bridge page to look not great since there's no data. I tested it with actual data and it looks good.

Testing

If you would like to test with real data, go to useStoreInitializer.ts and replace the vaultAddress with an address that has positions.

Copy link

vercel bot commented Jun 20, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
ion-yield-bridge ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 28, 2024 6:41am

@knoll3 knoll3 marked this pull request as draft June 20, 2024 15:38
@knoll3 knoll3 force-pushed the finish-yield-bridge branch from 5e17b50 to c10c5d2 Compare June 28, 2024 06:38
@knoll3 knoll3 marked this pull request as ready for review July 2, 2024 03:30
@knoll3 knoll3 merged commit 3d7f907 into main Jul 2, 2024
2 checks passed
@knoll3 knoll3 deleted the finish-yield-bridge branch July 2, 2024 03:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant