misc qa fixes #1817 #1811 #1812 #1816 #1860
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced May 29, 2018
Closed
stenington
suggested changes
May 29, 2018
| @@ -14,8 +14,8 @@ <h2>Congratulations!</h2> | |||
| to share with the community. | |||
| </p> | |||
| <div class="button-wrapper"> | |||
| <a href="{% url "challenges:examples" challenge_id=challenge.id %}" class="btn btn-primary">Go to the Inspiration Gallery</a> | |||
| <a href="{% url 'profiles:home' %}" class="btn btn-primary">Return to Dashboard</a> | |||
| <a href="{% url "challenges:examples" challenge_id=challenge.id %}" class="btn btn-primary congratulations-button">Go to the Inspiration Gallery</a> | |||
There was a problem hiding this comment.
I don't see this class being used for anything. Is it necessary?
| .btn-link { | ||
| color: #fff; | ||
| } | ||
| label {display: none;} |
There was a problem hiding this comment.
Expand this out to 3 lines:
label {
display: none;
}
| p { | ||
| margin: 20px 0; | ||
| } | ||
| a { color: #fff;} |
There was a problem hiding this comment.
Expand this out to three lines as well.
stenington
approved these changes
Jun 4, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1817 The pink of 'test' is being replaced with the orange of 'build.'
#1811 Build Test Redesign is now all orange.
#1812 Feedback quizzes are now grey.
#1816 Feedback results are now grey. The buttons on congratulations now have margins on the bottom for narrow views.