Remove submissions with more than 4 recusals #5403
Conversation
viviancan
force-pushed
the
5335-remove-submissions-with-more-than-5-recusals
branch
from
50e3cf1 to
dc57def
Compare
| @@ -7,7 +7,7 @@ class ScoredSubmissionsGrid | |||
|
|
|||
| scope do | |||
| TeamSubmission.complete.current | |||
| .includes(:team, {submission_scores: :judge_profile}) | |||
| .includes(team: :division, submission_scores: :judge_profile) | |||
There was a problem hiding this comment.
Fixed bullet warning
viviancan
force-pushed
the
5335-remove-submissions-with-more-than-5-recusals
branch
from
ed3d453 to
8e4246a
Compare
viviancan
changed the title
| @@ -128,6 +128,9 @@ def developed_on?(platform_name) | |||
| scope :complete, -> { where("published_at IS NOT NULL") } | |||
| scope :incomplete, -> { where("published_at IS NULL") } | |||
|
|
|||
| scope :removed_from_judging_pool, -> { where(removed_from_judging_pool: true) } | |||
| scope :not_removed_from_judging_pool, -> { where(removed_from_judging_pool: false) } | |||
There was a problem hiding this comment.
Unsure of the scope names. I think removed_from_judging_pool is pretty straight forward but I'm wondering if the other should be eligble_for_judging or something more general like that?
There was a problem hiding this comment.
Yeah, I like where you're headed, eligible_for_judging or something like that. 👍 And I could even see that scope containing complete too, as in an eligible submission for judging is a complete submission that hasn't been removed from the judging pool.
| @@ -10,6 +10,7 @@ class ScoresController < AdminController | |||
| unless request.xhr? | |||
| @round = grid_params[:round] | |||
| end | |||
| @removed_submissions = TeamSubmission.current.complete.removed_from_judging_pool | |||
There was a problem hiding this comment.
Reading removed_submissions this seems to be a little vague to me, suggestion: submissions_removed_from_judging_pool or something more descriptive.
| @@ -84,6 +84,10 @@ class ScoredSubmissionsGrid | |||
|
|
|||
| column :judge_recusal_count, header: "Recusals", mandatory: true, order: true | |||
|
|
|||
| column :removed_from_judging_pool, header: "Removed from judging pool", mandatory: true do |submission| | |||
| ApplicationController.helpers.humanize_boolean(submission.removed_from_judging_pool) | |||
There was a problem hiding this comment.
Using removed_from_judging_pool? would be more explicit that this returns a boolean (by convention); and since we're using a humanize_boolean helper vs the method w/o the ? (which will do the same thing, just doesn't follow the ? convention).
| @@ -565,4 +567,8 @@ def pending_approval? | |||
| def update_team_score_summaries | |||
| team_submission.update_score_summaries | |||
| end | |||
|
|
|||
| def update_removed_from_judging_pool | |||
| team_submission.reload.update(removed_from_judging_pool: team_submission.judge_recusal_count > 4) | |||
There was a problem hiding this comment.
I'm wondering if making this more explicit would make it easier to parse:
if recusal count >= 5
remove from judging pool
The basic format being:
- if this, set that
vs.
- set this to result of conditional
Just a random thought. 🙂
Refs #5335 and #5336
This PR adds functionality to automatically remove a submission from the judging pool on the 5th recusal.
Key Changes:
remove_from_judging_poolboolean field to team_submissionsremove_from_judging_poolto true whenjudge_recusal_count exceeds4 recusals