Added endPortalPick setting #722
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
sh0inx
commented
Aug 5, 2023
sh0inx
commented
- added endPortalPick configuration setting to allow the end portal frames to be picked up and placed again, as they are indestructable blocks (right click with wooden pickaxe, consumes pickaxe)
- restructured PlayerInteractListener to accommodate multiple listening targets
- added endPortalPick configuration setting to allow the end portal frames to be picked up and placed again, as they are indestructable blocks (right click with wooden pickaxe, consumes pickaxe) - restructured PlayerInteractListener to accommodate multiple listening targets
PeachesMLG
reviewed
Aug 6, 2023
src/main/java/com/iridium/iridiumskyblock/listeners/PlayerInteractListener.java
Outdated
Show resolved
Hide resolved
src/main/java/com/iridium/iridiumskyblock/listeners/PlayerInteractListener.java
Outdated
Show resolved
Hide resolved
src/main/java/com/iridium/iridiumskyblock/listeners/PlayerInteractListener.java
Outdated
Show resolved
Hide resolved
src/main/java/com/iridium/iridiumskyblock/listeners/PlayerInteractListener.java
Outdated
Show resolved
Hide resolved
| && event.getClickedBlock().getType().equals(Material.END_PORTAL_FRAME) | ||
| && itemInHand.getType().equals(Material.WOODEN_PICKAXE)) { | ||
|
|
||
| event.getClickedBlock().setType(Material.AIR); |
There was a problem hiding this comment.
Have you verified if this also breaks the portal if activated?
There was a problem hiding this comment.
I have not, I'll test today
PeachesMLG
reviewed
Aug 10, 2023
Comment on lines
57
to
61
| event.getClickedBlock().getDrops().add(new ItemStack(Material.END_PORTAL_FRAME)); | ||
| event.getClickedBlock().breakNaturally(); | ||
|
|
||
| player.getInventory().addItem(new ItemStack(Material.END_PORTAL_FRAME)).values().forEach(itemStack -> | ||
| player.getWorld().dropItem(player.getLocation(), itemStack)); |
There was a problem hiding this comment.
Why are we adding this to the drops and the player's inventory?
There was a problem hiding this comment.
adding to the drops doesn't do anything, i'll remove that line
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.