Added Stacker Support #812
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
sh0inx
commented
Feb 24, 2024
sh0inx
commented
- changed recalculate method to include support from the support manager
- changed recalculate method to include support from the support manager
MertUnverdi
reviewed
Feb 26, 2024
src/main/java/com/iridium/iridiumskyblock/managers/IslandManager.java
Outdated
Show resolved
Hide resolved
- Updated lists to HashSets to avoid duplicate support injections - Fixed an issue with the plugin only checking from y=0 for teamBlocks - Added a condition to skip the loop if the block being inspected is of type AIR, CAVE_AIR, or VOID_AIR - Added ObsidianStacker to the soft dependencies list
- added a teamBlock filter to not iterate through every item in the game for every block on the island
PeachesMLG
reviewed
Mar 16, 2024
src/main/java/com/iridium/iridiumskyblock/managers/IslandManager.java
Outdated
Show resolved
Hide resolved
src/main/java/com/iridium/iridiumskyblock/managers/IslandManager.java
Outdated
Show resolved
Hide resolved
- removed essentials dependency as its now included in teams - added `spawnOnIsland` to force players to respawn on their islands (if they exist), includes new PlayerRespawnEventListener - removed the island check for `PlayerInteractEventListener` as it was conflicting with teams - changed the WordUtils import location - removed unnecessary imports and inlined a few things in `IslandManager` - rewrote `PlayerUtils` to use support manager from teams
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.