Fix flake builder -- again #114
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So... turns out that last time it was actually not building with the rust toolchain that was specified and there was an error that was thrown when building ironhide from my system config which wasn't thrown otherwise. Things would have worked right in a developer shell and things appeared to work right when calling
nix runornix build.The critical change is to go from using the
pkgs.rustPlatformwhich is not overriden by oxalaca to callingpkgs.makeRustPlatformand passing in the oxalaca binaries needed for the build (cargo and rustc).I pushed this up as a branch and had my system config point to this branch to test it. It does work now. Sorry for the multiple PRs.