Enable 32-bit tests during CI #1180
Conversation
|
@slozier what's stopping this from being merged? |
|
I don't remember why I left this one as a draft. Maybe something was failing? Or Windows 11 being 64-bit only made testing it less interesting. I guess I can rebase and see if anything is failing. |
There was a problem hiding this comment.
It looks like there was an error with the build .NET > IronLanguages > Pipelines
1>D:\a\1\s\Directory.Build.props(105,3): error MSB4019: The imported project "D:\a\1\s\Build\net46.props" was not found. Confirm that the expression in the Import declaration "D:\a\1\s\Build\net46.props" is correct, and that the file exists on disk. [D:\a\1\s\Src\IronPythonTest\IronPythonTest.csproj]
The correct props file is net462 and not net46.
Build/steps.yml
Outdated
| @@ -81,6 +81,11 @@ steps: | |||
| - powershell: ./make.ps1 test-all | |||
| displayName: Test | |||
|
|
|||
| # 32-bit tests on Windows only | |||
| - ${{ if eq(parameters.os, 'Windows') }}: | |||
| - powershell: ./make.ps1 -frameworks net46 -platform x86 test-all | |||
There was a problem hiding this comment.
| - powershell: ./make.ps1 -frameworks net46 -platform x86 test-all | |
| - powershell: ./make.ps1 -frameworks net462 -platform x86 test-all |
|
How is the check still running? |
|
Ahh, a bunch of tests are not actually running in 32-bit mode because the process runner is launching ipy.exe. Seems vaguely familiar - probably why I moved it to draft in the first place. Guess I should have left a note. 😄 |
|
Closing this one as it just increases CI time considerably for little to no gain. |
No description provided.