-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pin apk packages #380
Pin apk packages #380
Conversation
ENV \ | ||
# renovate: datasource=repology depName=alpine_3_20/bash | ||
BASH_VERSION=5.2.26-r0 \ | ||
# renovate: datasource=repology depName=alpine_3_20/curl |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We'll have to remember to update alpine_3_20
when we change the base alpine
layer, though I suspect builds will fail if we reference older versions of packages. So I doubt we'll run into a discrepancy, since builds will fail.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah i was thinking this afternoon about how we'll bump to alpine 3.21. Figured I'd wait until your cache changes are in and then put some code in place to facilitate those sorts of bumps. But pretty sure we can get a script to do it for us.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If ENV
becomes ARG
I'm happy to merge this as is. Good stuff!
We can use renovate's repology datasource to update pinned apk packages.
Renovate basically looks for updates at https://pkgs.alpinelinux.org/packages?name=&branch=v3.20 and will bump the respective version in our Dockerfiles along with our other dependency updates. This will give us a little more visibility into what all changes version to version when we cut new releases.