Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin apk packages #380

Merged
merged 5 commits into from
Feb 12, 2025
Merged

Pin apk packages #380

merged 5 commits into from
Feb 12, 2025

Conversation

joecorall
Copy link
Contributor

@joecorall joecorall commented Feb 11, 2025

We can use renovate's repology datasource to update pinned apk packages.

Renovate basically looks for updates at https://pkgs.alpinelinux.org/packages?name=&branch=v3.20 and will bump the respective version in our Dockerfiles along with our other dependency updates. This will give us a little more visibility into what all changes version to version when we cut new releases.

@joecorall joecorall marked this pull request as ready for review February 11, 2025 18:41
base/Dockerfile Outdated Show resolved Hide resolved
ENV \
# renovate: datasource=repology depName=alpine_3_20/bash
BASH_VERSION=5.2.26-r0 \
# renovate: datasource=repology depName=alpine_3_20/curl
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We'll have to remember to update alpine_3_20 when we change the base alpine layer, though I suspect builds will fail if we reference older versions of packages. So I doubt we'll run into a discrepancy, since builds will fail.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah i was thinking this afternoon about how we'll bump to alpine 3.21. Figured I'd wait until your cache changes are in and then put some code in place to facilitate those sorts of bumps. But pretty sure we can get a script to do it for us.

Copy link
Contributor

@nigelgbanks nigelgbanks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If ENV becomes ARG I'm happy to merge this as is. Good stuff!

@nigelgbanks nigelgbanks merged commit abbaf92 into main Feb 12, 2025
80 checks passed
@nigelgbanks nigelgbanks deleted the pin-packages branch February 12, 2025 00:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants