Feature/better escaping

[adam-vessey]

GitHub Issue: (link)

• Other Relevant Links (Google Groups discussion, related pull requests, Release pull requests, etc.)

What does this Pull Request do?

Allows command invocations to be passed as arrays, in order to make use of PHP's improved escaping mechanisms (as of PHP 7.4, in proc_open())

What's new?

Callers may now pass commands to be executed as an array.

• Changes x feature to such that y
• Added x
• Removed y
• Does this change require documentation to be updated? Not aware of any.
• Does this change add any new dependencies? Not really, though the use of PHP 8.0's match() might be pulling up the minimum PHP that things will run against. We only test on 8.1+, so probably not an issue?
• Does this change require any other modifications to be made to the repository (i.e. Regeneration activity, etc.)? No.
• Could this change impact execution of existing code? Shouldn't, unless running PHP <8.0.

How should this be tested?

Run the tests. Can be run on each commit individually by checking out and then running. The first commit, the "string" invocations should work and the "array" invocations fail. The second commit has both working.

Additional Notes:

Any additional information that you think would be helpful when reviewing this PR.

Interested parties

Tag (@ mention) interested parties or, if unsure, @Islandora/committers

[seth-shaw-asu]

Could you also update the badge and requirements section of the README? Just so we can keep it consistent.

[seth-shaw-asu]

I'll try to get this tested on Monday if I run out of time today.

[adam-vessey]

Could you also update the badge and requirements section of the README? Just so we can keep it consistent.

Sure thing, just noticed it actually. Had initially just looked in the composer.json for any constraints on PHP there, and not really thought any more of it. :P

[seth-shaw-asu]

Note to self (or anyone else who is interested in this); I'm trying to get better about developing in docker containers, so I made the following Dockerfile to help me run tests for this PR: https://gist.github.com/seth-shaw-asu/a07d998f2124be52abb45ce30bcc09bd