Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include islandora_fits into islandora/modules #907

Closed
wants to merge 94 commits into from

Conversation

rosiel
Copy link
Member

@rosiel rosiel commented Nov 7, 2022

GitHub Issue: #906

What does this Pull Request do?

Includes Islandora Fits as a submodule of Islandora.

What's new?

  • Islandora Fits submodule, including its git history.

  • Added a dependency to composer.json for ext-simpleXML, required by Islandora FITS so it can parse XML.

  • Does this change add any new dependencies? - yes, simpleXML. will be installed automatically when using Composer to update islandora.

  • Does this change require any other modifications to be made to the repository
    (i.e. Regeneration activity, etc.)?

  • Could this change impact execution of existing code? no, shouldn't.

How should this be tested?

To upgrade to this version:

  • add this branch as a repository in your composer.json, and change the spec for "islandora/islandora" to "dev-include-fits" (won't be required after merging).
  • composer remove "islandora-rdm/islandora_fits"
  • composer update -W "islandora/islandora" (make sure you get the new code)
  • cache refresh and restart your webserver so PHP finds the files in their new locations.
  • FITS derivatives should work exactly as before.
  • Note: I did NOT merge the islandora_fits_tags migration with the islandora tags migration. I'm not sure we should, since this is an optional module. But i'm open to suggestions.

Documentation Status

  • Does this change existing behaviour that's currently documented? - no, same behaviour
  • Does this change require new pages or sections of documentation? - no
  • Who does this need to be documented for? - n/a
  • Associated documentation pull request(s): ___ or documentation issue ___

Deployment Status (post-commit)

  • Starter Site - will need an update (removing islandora_fits from composer when locking to this version of islandora)
  • Install Profile - will need an update (removing islandora_fits)

Additional Notes:

Any additional information that you think would be helpful when reviewing this
PR.

Interested parties

Tag (@ mention) interested parties or, if unsure, @Islandora/committers

@adam-vessey
Copy link

Don't appear to be able to comment on it directly, but modules/islandora_fits/migrations/.swp probably shouldn't exist.

modules/islandora_fits/README.md Outdated Show resolved Hide resolved
modules/islandora_fits/README.md Outdated Show resolved Hide resolved
@adam-vessey adam-vessey removed their request for review September 27, 2023 17:42
@rosiel
Copy link
Member Author

rosiel commented Sep 27, 2023

Closing as the composer requirements exceed what you might need with an islandora. Instead, I'll see about transferring the repo to the Foundation.

@rosiel rosiel closed this Sep 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants