Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

moving electron to 33.4.1, and multiple auth refresh tries #1576

Conversation

IsmaelMartinez
Copy link
Owner

  • Removing enableBackgroundCallsAuthentication config option as it was broken, and probably not doing anything for us
  • Update electron to 33.4.1
  • Add website next to PWA in the bug template
  • Adding permissionCheckHandler config option to verify if 3rd party cookies are affecting token refreshing. Default allowed domains/permissions are:
allowedDomains : [ 'microsoft.com', 'microsoftonline.com', 'teams.skype.com', 'teams.microsoft.com', 'sfbassets.com','skypeforbusiness.com'], allowedPermissions: [ 'background-sync', 'notifications', 'media', 'speaker-selection']

Fixes #1573
Trying to fix #1357 (but I don't think it fully works... but worth a try I guess)

@IsmaelMartinez IsmaelMartinez merged commit 607be72 into main Feb 21, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Please sign in again? - Way to keep non-idle? [Bug]: Preview of office files not working anymore
1 participant