Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MOB-10781] updates cooldown period constant #892

Merged
merged 3 commits into from
Feb 3, 2025
Merged

[MOB-10781] updates cooldown period constant #892

merged 3 commits into from
Feb 3, 2025

Conversation

evantk91
Copy link
Collaborator

@evantk91 evantk91 commented Jan 31, 2025 •
edited by jira bot
Loading

🔹 Jira Ticket(s)

✏️ Description

This pull request updates the cooldown period constant to be in milliseconds. The lastCriteriaFetch is logged in milliseconds so the cooldown period needs to be too.

joaodordio
joaodordio reviewed Feb 3, 2025
View reviewed changes
swift-sdk/Core/Constants.swift
@@ -26,7 +26,7 @@ enum Const {
static let deepLinkRegex = "/a/[a-zA-Z0-9]+"
static let href = "href"
static let exponentialFactor = 2.0
static let criteriaFetchingCooldown = 120.0 // 120 seconds = 120,000 milliseconds
static let criteriaFetchingCooldown = 120000.0 // 120 seconds = 120,000 milliseconds
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a very nice catch @evantk91 👏

joaodordio
joaodordio approved these changes Feb 3, 2025
View reviewed changes
Copy link
Member

@joaodordio joaodordio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've taken the opportunity to update some documentation and refactored some tiny code.

Nice catch!

@evantk91 evantk91 merged commit c138ef9 into feature/itbl_track_anon_user Feb 3, 2025
1 of 2 checks passed
@evantk91 evantk91 deleted the evan/criteria-fetching-corrections branch February 3, 2025 21:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joaodordio joaodordio joaodordio approved these changes

@sumeruchat sumeruchat Awaiting requested review from sumeruchat

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@evantk91 @joaodordio