Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implement missed bukkit things #1625

Merged
merged 4 commits into from
Feb 1, 2025
Merged

Conversation

sj-hub9796
Copy link
Contributor

No description provided.

@qyl27
Copy link
Collaborator

qyl27 commented Jan 17, 2025

Would you mind migrating the @Overwrite by the @Decorate in izzel-tools ?

@sj-hub9796
Copy link
Contributor Author

Would you mind migrating the @Overwrite by the @Decorate in izzel-tools ?

of course, but i'm busy atm. i'll look into it tomorrow.

@qyl27
Copy link
Collaborator

qyl27 commented Jan 17, 2025

No matter when. And, thank you.

@sj-hub9796
Copy link
Contributor Author

sj-hub9796 commented Jan 28, 2025

No matter when. And, thank you.

heya, sry for late.

BannerPatternLayers.CODEC.parse(provider.createSerializationContext(NbtOps.INSTANCE), compoundTag.get("patterns")).resultOrPartial((string) -> {
                LOGGER.error("Failed to parse banner patterns: '{}'", string);
            }).ifPresent((bannerPatternLayers) -> {
                this.patterns = bannerPatternLayers; // <- Here
            });

this field is inside the lambda, so I have no idea about it.
do you have any idea?

@qyl27
Copy link
Collaborator

qyl27 commented Jan 29, 2025

Yes, things inside the lambda is actually an anonymous method or inner anonymous class.
You can view the bytecode and get its name, in this case, it is method_58121 in 1.21.1.

@sj-hub9796
Copy link
Contributor Author

method_58121

Thx!

@AgentMelinda
Copy link

AgentMelinda commented Jan 29, 2025

@sj-hub9796 could you pretty please help on this matter pretty please ? 😃
#1455 (comment)

@sj-hub9796
Copy link
Contributor Author

@sj-hub9796 이 문제에 대해 도와주세요. 제발 제발? 😃 # 1455

yea, i'll look into it when i'm free

@sj-hub9796
Copy link
Contributor Author

@qyl27 heya! please can you review bba99c4?

@sj-hub9796
Copy link
Contributor Author

@qyl27 heya! please can you review bba99c4?

oh, no. wait. i missed something let me quick fix

@sj-hub9796
Copy link
Contributor Author

alright, done!

@sj-hub9796
Copy link
Contributor Author

also bring mod sign fix from #1586

@AgentMelinda
Copy link

@sj-hub9796 이 문제에 대해 도와주세요. 제발 제발? 😃 # 1455

yea, i'll look into it when i'm free

thank you so much ❤️

Copy link
Collaborator

@qyl27 qyl27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh, yeah, thank you

@qyl27 qyl27 merged commit a842e85 into IzzelAliz:FeudalKings Feb 1, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants