Add retry option based on Retry from urllib3.util #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fixed allowed_methods to GET Co-authored-by: Jonathan de Bruin <[email protected]>
J535D165
reviewed
Oct 19, 2023
added error 429 support Co-authored-by: Jonathan de Bruin <[email protected]>
J535D165
approved these changes
Oct 19, 2023
J535D165
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following this pull request, I reimplemented the retry with urllib3.util.Retry
This is based on this example from the
requestsdocumentation.The retry option is disabled by default. However, the user can set the maximum number of retries, delay, and HTTP error codes to manage with the following parameters:
I added the errors 500 and 503 as they are the ones that we were experiencing and identified in the last pull request as coming from the OpenAlex API.