Ensure that filter values are URL encoded #42
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edsu
force-pushed
the
filter-urlencode
branch
2 times, most recently
from
f929e32 to
c0a6077
Compare
edsu
commented
Jun 26, 2024
| @@ -38,3 +38,7 @@ select = ["E", "F", "UP", "I", "B"] | |||
|
|
|||
| [tool.ruff.lint.isort] | |||
| force-single-line = true | |||
|
|
|||
| [tool.pytest.ini_options] | |||
There was a problem hiding this comment.
I needed to add this to get pytest to work with uv.
uv venv
uv pip compile pyproject.toml -o requirements.txt
uv pip install -r requirements.txt
pytest
Let me know if there's a preferred way of running the tests, I can remove this change.
There was a problem hiding this comment.
Thanks. Haven't played with uv yet, but will do soon. For now, all tests seem to pass with this new config. I will merge.
There are some cases where the filter query needs to be URL encoded, such as when querying for a DOI that has an ampersand in it. Fixes J535D165#41
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are some cases where the filter query needs to be URL encoded, such as when querying for a DOI that has an ampersand in it.
Fixes #41