Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SP] Force power Timing Fix #1255

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

BE-Arbiter
Copy link

Fix Force power activating to many time per second at high fps.

@BE-Arbiter BE-Arbiter requested a review from a team as a code owner March 1, 2025 20:50
@ensiform
Copy link
Member

ensiform commented Mar 2, 2025

This adds new fields to saves breaking compat, however.

@BE-Arbiter
Copy link
Author

Having a better alternative ?

@ensiform
Copy link
Member

ensiform commented Mar 2, 2025

Don't put in playerstate

@BE-Arbiter
Copy link
Author

Where would you put it ? Isn't ent->s also save breaking? In a logic standpoint it's where all force properties are stored and its not like a table of size max_entities would be an elegant solution...

@ensiform
Copy link
Member

ensiform commented Mar 2, 2025

Where would you put it ? Isn't ent->s also save breaking? In a logic standpoint it's where all force properties are stored and its not like a table of size max_entities would be an elegant solution...

Any reason why it has to be in the entity state or player state at all, not just part of the client struct?

@BE-Arbiter
Copy link
Author

it's more clean to my psychorigid mind. Will make your proposed adaptations

@BE-Arbiter
Copy link
Author

Is it better now ? :)

@ensiform
Copy link
Member

ensiform commented Mar 2, 2025

Well it will not compile, you put it in entity structure and reference it in client structure.

removed problematic client->
@BE-Arbiter
Copy link
Author

There.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants