-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mongolia bur2 remaining tables #89
Conversation
The |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, but will not work with current code because of sector aggregation specifications.
If downscaling is necessary but not yet implemented we can take a look together,
"name": "Agriculture excluding livestock", | ||
}, | ||
"M.AG": {"sources": ["3.A", "M.AG.ELV"], "name": "Agriculture"}, | ||
"M.AG": {"sources": ["3.A.1", "3.A.2", "M.AG.ELV"], "name": "Agriculture"}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
3.A
is needed for PRIMAP-hist. If not present aggregate, if present why is it not used for M.AG
?
"M.AG": {"sources": ["3.A.1", "3.A.2", "M.AG.ELV"], "name": "Agriculture"}, | |
"3.A": {"sources": ["3.A.1", "3.A.2"], "name": "Agriculture"}, | |
"M.AG": {"sources": ["3.A", "M.AG.ELV"], "name": "Agriculture"}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is 3.A not the same as 3.A.1 and 3.A.2 in this case?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's the same in terms of building M.AG but we need 3.A as an independent category in PRIMAP-hist
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
3.A is in the overview tables. Do I still not to aggregate 3.A then?
@@ -343,18 +720,24 @@ | |||
# }, | |||
"M.3.D.AG": {"sources": ["3.D.2"], "name": "Other (Agriculture)"}, | |||
# TODO: In this case 3.C should be equivalent to M.3.C.AG, but I'm not sure. | |||
"M.3.C.AG": { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
are 3.C and 3.D present? If not aggregate them.
(From the sector mapping in the table definitions I assume they are present.)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
They are present in the overview tables. So that's fine?
filter_dims=None, | ||
cat_terminology_out=None, | ||
category_conversion=None, | ||
sectors_out=None, | ||
processing_info_country=country_processing_step1, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are all sectors and gases covered for all years, or do you se downscaling or do we have gaps? If there are gaps in subsectors / gases and no downscaling yet, we could take a look together.
=== Do not change lines below === { "chain": [], "cmd": "python3 src/unfccc_ghg_data/unfccc_reader/Mongolia/read_MNG_BUR2_from_pdf.py", "dsid": "4d062170-604c-4efd-afbf-5ce7f97e0e63", "exit": 0, "extra_inputs": [], "inputs": [ "/Users/danielbusch/Documents/UNFCCC_non-AnnexI_data/downloaded_data/UNFCCC/Mongolia/BUR2/20231112_BUR_II_MGL_Final.pdf", "/Users/danielbusch/Documents/UNFCCC_non-AnnexI_data/downloaded_data/UNFCCC/Mongolia/BUR2/20231112_NIR_MGL.pdf" ], "outputs": [ "extracted_data/UNFCCC/Mongolia/MNG_BUR2_2023_IPCC2006_PRIMAP_raw.csv", "extracted_data/UNFCCC/Mongolia/MNG_BUR2_2023_IPCC2006_PRIMAP.csv", "extracted_data/UNFCCC/Mongolia/MNG_BUR2_2023_IPCC2006_PRIMAP_raw.nc", "extracted_data/UNFCCC/Mongolia/MNG_BUR2_2023_IPCC2006_PRIMAP_raw.yaml", "extracted_data/UNFCCC/Mongolia/MNG_BUR2_2023_IPCC2006_PRIMAP.nc", "extracted_data/UNFCCC/Mongolia/MNG_BUR2_2023_IPCC2006_PRIMAP.yaml" ], "pwd": "." } ^^^ Do not change lines above ^^^
Work in progress.
notebook
to dependenciesipympl
to dependencies (needed to show interactive plots in jupyter notebooks)67, 78, 91, 105/6, 110/111