Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create interface variants of joml-primitives classes. #3

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

Rubydesic
Copy link

@Rubydesic Rubydesic commented Feb 25, 2021

In reference to #2. This pull request is a work-in-progress.

Current progress, interface variants for:

  • Circled
  • Circlef
  • LineSegmentd
  • LineSegmentf
  • Planed
  • Planef
  • Rayd
  • Rayf
  • Rectangled
  • Rectanglef
  • Rectanglei
  • Sphered
  • Spheref

@Rubydesic
Copy link
Author

This PR also fixes some methods that rely on the concrete implementation instead of the interface (i.e. intersectsAABB) and pulls some methods into the interface that don't mutate (i.e. length)

It also adds the following methods to AABB: volume, expand, signedDistanceTo

@Rubydesic Rubydesic marked this pull request as ready for review October 15, 2022 08:38
@Rubydesic
Copy link
Author

@httpdigest Requesting review.

@Rubydesic
Copy link
Author

@httpdigest Is this project unmaintained now?

@ultraq
Copy link

ultraq commented Jul 6, 2024

Ah, I was just looking into something like this for the primitives - it would be awesome if this could be included and released 🤞

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants