Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport of #288 to modular branch #295

Open
wants to merge 8 commits into
base: modular
Choose a base branch
from

Conversation

graag
Copy link

@graag graag commented Apr 22, 2024

Some fixes for modular branch. As the user analysis prepared by Kamil for positronium lifetime is not compatible with modular4 there are some corrections required to the modular branch to actually run it at CIŚ.

  1. Back port Add a built-in implementation of default MC smearing functions #288 to modular branch used by Roman and Kamil
  2. Fix a bug that prevents disabling the new default smearing functions (5c20095) - could be considered to cherry pick into master
  3. Compatibility fixes for GCC 13 (ad6435e)
  4. Store global time in MC hits (21c5c69) - this was developed by Kamil for analysis done by Roman and could be considered as breaking backwards compatibility ?? I'm not sure about this one - we can skip it and only store in dedicated branch for Positronium lifetime analysis :-/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants