Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Parsing LOCK Clause in ALTER TABLE Using JSQLParser #2090

Closed
minleejae opened this issue Oct 18, 2024 · 2 comments
Closed

[FEATURE] Parsing LOCK Clause in ALTER TABLE Using JSQLParser #2090

minleejae opened this issue Oct 18, 2024 · 2 comments
Labels
DDL DDL statement related MySQL MySQL specific issue Sponsor needed

Comments

@minleejae
Copy link
Contributor

Grammar or Syntax Description

The LOCK=NONE clause in ALTER TABLE statements is not correctly parsed by JSQLParser. The parser successfully parses the statement into three AlterExpression objects, but the LOCK=NONE part is treated as UNSPECIFIC instead of identifying it as a proper ALTER OPERATION related to table locking behavior. This can cause ambiguity in the interpretation of certain ALTER TABLE statements.

SQL Example

ALTER TABLE sbtest1 MODIFY COLUMN pad_3 VARCHAR(20) DEFAULT NULL, ALGORITHM=INPLACE, LOCK=NONE;

Additional context

  • Applicable RDBMS: MySQL 8.0 and later
  • JSQLParser Version: 5.0

The parsing succeeds without errors, but I believe it is necessary to add an appropriate LOCK or AlterOperation type to handle clauses like LOCK=NONE properly.

@manticore-projects
Copy link
Contributor

Greetings!
You will need to provide or sponsor an implementation to make this happen.

@manticore-projects
Copy link
Contributor

Solved via #2095

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DDL DDL statement related MySQL MySQL specific issue Sponsor needed
Projects
None yet
Development

No branches or pull requests

3 participants
@manticore-projects @minleejae and others