Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue 2090: Correctly parse LOCK clause in ALTER TABLE statements #2095

Merged
merged 2 commits into from
Oct 24, 2024

Conversation

minleejae
Copy link
Contributor

Summary

This PR addresses issue #2090 by adding support for parsing the LOCK clause in ALTER TABLE statements in JSQLParser. Previously, the LOCK=NONE clause was incorrectly parsed as UNSPECIFIC, causing ambiguity in the interpretation of certain ALTER TABLE statements.

Changes

Updated AlterOperation enum to include LOCK.
Modified the parser to correctly identify and handle the LOCK clause.

@manticore-projects
Copy link
Contributor

Greetings! Looks very clean, fantastic job! Thank you for your contribution, I will merge promptly when QA/CI tests have passed! Kudos.

@manticore-projects
Copy link
Contributor

Please, run './gradlew :spotlessApply' to fix these violations.

@minleejae
Copy link
Contributor Author

@manticore-projects

Hi, I’m working on a personal project involving MySQL DDL, and I’ve encountered several DDL statements that are not being parsed correctly. I’m actively working on fixing as many of these issues as I can. I was wondering if you have any plans for the release date of version 5.1? I’d like to contribute as much as possible before the 5.1 release.

Thank you!

@manticore-projects
Copy link
Contributor

Greetings to Seoul and welcome!

I personally have only little interest in DDL outside of Oracle. So you contribution is most welcome and appreciated! Keep sending please!

All the best and cheers!
(I miss Korea so much!)

@manticore-projects manticore-projects merged commit f3f6b72 into JSQLParser:master Oct 24, 2024
3 checks passed
@manticore-projects
Copy link
Contributor

Release Date for 5.1 is likely around December/January. No fixed plans, we do it when we have time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants