Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Gradle JavaCC parser to latest version (3.0.0) #1843

Merged
merged 1 commit into from
Aug 5, 2023

Conversation

zbynek
Copy link
Contributor

@zbynek zbynek commented Aug 5, 2023

New version of the JavaCC plugin is out: release notes. Because the plugin ID changed, it won't be found by usual dependency update mechanisms, so I'm making PRs manually to update the major projects on GitHub that are using an older version of the plugin.

The new version should make compilation of the parser a bit faster and improve compatibility with future releases of Gradle.

I locally checked that ./gradlew test is successful with this change, but have not done any other testing.

Personally I'd suggest to use specific versions of plugins in the Gradle file rather than latest.release, but I did not change it here.

The warnings before and after seem to be the same:

Warning:  "RR" cannot be matched as a string literal token at line 1749, column 2413. It will be matched as  <K_ISOLATION>.
Warning:  "UR" cannot be matched as a string literal token at line 1749, column 2982. It will be matched as  <K_ISOLATION>.
Warning:  "CS" cannot be matched as a string literal token at line 1749, column 638. It will be matched as  <K_ISOLATION>.
Warning:  "RS" cannot be matched as a string literal token at line 1749, column 2423. It will be matched as  <K_ISOLATION>.
Warning:  "RETURN" cannot be matched as a string literal token at line 1262, column 39. It will be matched as  <S_IDENTIFIER>.
Warning:  "UNQUIESCE" cannot be matched as a string literal token at line 6443, column 13. It will be matched as  <S_IDENTIFIER>.
Warning:  "INVALIDATE" cannot be matched as a string literal token at line 6146, column 23. It will be matched as  <S_IDENTIFIER>.
Warning:  "CONSTRAINTS" cannot be matched as a string literal token at line 6150, column 27. It will be matched as  <S_IDENTIFIER>.
Warning:  "TIMESTAMPTZ" cannot be matched as a string literal token at line 1749, column 2806. It will be matched as  <K_DATETIMELITERAL>

@manticore-projects
Copy link
Contributor

Awesome! Thank you very much!

@manticore-projects manticore-projects merged commit c59a088 into JSQLParser:master Aug 5, 2023
3 of 5 checks passed
@zbynek zbynek deleted the javacc-parser branch August 6, 2023 05:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants