Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add support comment in create view for MySQL and MariaDb #1913

Merged
merged 6 commits into from
Dec 14, 2023
Merged

feat: Add support comment in create view for MySQL and MariaDb #1913

merged 6 commits into from
Dec 14, 2023

Conversation

jxnu-liguobin
Copy link
Contributor

No description provided.

@jxnu-liguobin jxnu-liguobin changed the title feat: Add support comment in create view for mysql feat: Add support comment in create view for MySQL and mariaDb Dec 14, 2023
@jxnu-liguobin jxnu-liguobin changed the title feat: Add support comment in create view for MySQL and mariaDb feat: Add support comment in create view for MySQL and MariaDb Dec 14, 2023
manticore-projects
manticore-projects requested changes Dec 14, 2023
View reviewed changes
Copy link
Contributor

@manticore-projects manticore-projects left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution.
It looks great in general but I wonder if we can reuse the existing Production ColumnDefinition and use an ExpressionList for the collection.

src/main/jjtree/net/sf/jsqlparser/parser/JSqlParserCC.jjt Outdated
@@ -5705,13 +5705,44 @@ Analyze Analyze():
}
}

ColumnDefinition ColumnDefinitionItem():
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There should be a similar Production already, please try to re-use it.

src/main/jjtree/net/sf/jsqlparser/parser/JSqlParserCC.jjt Outdated
}
}

List<ColumnDefinition> ColumnDefinitionItemList():
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please try to use an ExpressionList<Column> here.

@manticore-projects manticore-projects merged commit 4d47e0a into JSQLParser:master Dec 14, 2023
2 of 5 checks passed
@manticore-projects
Copy link
Contributor

Thank you for your very good contribution, we do appreciate!

@manticore-projects
Copy link
Contributor

Please would you still like to fix the Grammar regarding

Warning: Choice conflict in [...] construct at line 1774, column 5.
         Expansion nested within construct and expansion following construct
         have common prefixes, one of which is: "COMMENT"
         Consider using a lookahead of 2 or more for nested expansion.

@jxnu-liguobin
Copy link
Contributor Author

COMMENT

ok

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@manticore-projects manticore-projects manticore-projects requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jxnu-liguobin @manticore-projects