Fix parsing ALTER TABLE ... ADD COLUMNS (...)
#2087
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
njaremko
commented
Oct 15, 2024
| ( | ||
| <K_COLUMN> { alterExp.hasColumn(true); } | ||
| | | ||
| <K_COLUMNS> { alterExp.hasColumns(true); } |
There was a problem hiding this comment.
It seems I auto-formatted this file. This is the only change, but I can remove the formatting bit if that matters.
njaremko
force-pushed
the
nathan/fix-alter-columns-parse
branch
from
84ed566
to
9672d76
Compare
|
Thank you for your contribution, please fix formatting exception by running './gradlew :spotlessApply' to fix these violations. |
The current behaviour fails when it encounters `ADD COLUMNS` and merges everything in the `()` into one string with no whitespace. So `ALTER TABLE catalog.table.name ADD COLUMNS (apples int)` becomes `ALTER TABLE catalog.table.name ADD COLUMNS (applesint)`. This commit adds an understanding of how `ADD COLUMNS` to the grammar.
njaremko
force-pushed
the
nathan/fix-alter-columns-parse
branch
from
9672d76
to
bcdadc8
Compare
|
Done |
|
Thank you for your contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current behaviour fails when it encounters
ADD COLUMNSand merges everything in the()into one string with no whitespace.So
ALTER TABLE catalog.table.name ADD COLUMNS (apples int)becomesALTER TABLE catalog.table.name ADD COLUMNS (applesint).This commit adds an understanding of
ALTER TABLE ... ADD COLUMNSto the grammar.