Improvement remove requirements txt #143
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
dependencies
mahenning
reviewed
Jan 9, 2025
| @@ -17,8 +17,6 @@ classifiers = [ | |||
| 'Intended Audience :: Developers', | |||
| 'License :: OSI Approved :: GNU General Public License v3 (GPLv3)', | |||
| 'Programming Language :: Python :: 3.8', | |||
There was a problem hiding this comment.
'Programming Language :: Python :: 3.8' also remove?
| @@ -17,8 +17,6 @@ classifiers = [ | |||
| 'Intended Audience :: Developers', | |||
| 'License :: OSI Approved :: GNU General Public License v3 (GPLv3)', | |||
| 'Programming Language :: Python :: 3.8', | |||
| 'Programming Language :: Python :: 3.9', | |||
| 'Programming Language :: Python :: 3.10', | |||
| 'Programming Language :: Python :: 3.11', | |||
| 'Environment :: GPU :: NVIDIA CUDA :: 12 :: 12.1', | |||
There was a problem hiding this comment.
The base image now uses CUDA 12.4, not sure how important it is here
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove
requirement.txt.Therefore, adjusted Dockerfile, and actions