Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable ./gradlew run on Windows if more dependencies are used #11451

Merged
merged 2 commits into from
Jul 4, 2024
Merged

Conversation

koppor
Copy link
Member

@koppor koppor commented Jul 4, 2024

We get error 206 on Windows if we add more dependencies. See InAnYan#5 for details.

There is a fix (java9-modularity/gradle-modules-plugin#282). This PR ports this fix to the main branch to enable new branches on Windows.

Mandatory checks

  • Change in CHANGELOG.md described in a way that is understandable for the average user (if applicable)
  • Tests created for changes (if applicable)
  • Manually tested changed features in running JabRef (always required)
  • Screenshots added in PR description (for UI changes)
  • Checked developer's documentation: Is the information available and up to date? If not, I outlined it in this pull request.
  • Checked documentation: Is the information available and up to date? If not, I created an issue at https://github.com/JabRef/user-documentation/issues or, even better, I submitted a pull request to the documentation repository.

@koppor koppor requested a review from calixtus July 4, 2024 19:44
Copy link
Contributor

github-actions bot commented Jul 4, 2024

The build for this PR is no longer available. Please visit https://builds.jabref.org/main/ for the latest build.

@koppor koppor enabled auto-merge July 4, 2024 20:11
@koppor koppor mentioned this pull request Jul 4, 2024
6 tasks
@koppor koppor added this pull request to the merge queue Jul 4, 2024
Merged via the queue into main with commit 88b06a7 Jul 4, 2024
25 of 26 checks passed
@koppor koppor deleted the fix-run branch July 4, 2024 22:48
koppor added a commit that referenced this pull request Jul 8, 2024
koppor added a commit that referenced this pull request Jul 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants