Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix indexing task progress #11822

Merged
merged 1 commit into from
Sep 24, 2024
Merged

Fix indexing task progress #11822

merged 1 commit into from
Sep 24, 2024

Conversation

LoayGhreeb
Copy link
Collaborator

@LoayGhreeb LoayGhreeb commented Sep 24, 2024

Closes #11819.
The issue will be resolved if the PR for hiding completed background tasks (#11821) is merged.

However, this PR fixes the issue even if hiding completed tasks isn't implemented. Progress was shown with an empty title and no progress because sometimes background indexing tasks start but have no files to add to the index.
There was no control to show the task to the user after it started executing. This PR added this option.
Calling task.showToUser(true) after executeWith will show the task if it's still running.

Mandatory checks

  • Change in CHANGELOG.md described in a way that is understandable for the average user (if applicable)
  • Tests created for changes (if applicable)
  • Manually tested changed features in running JabRef (always required)
  • Screenshots added in PR description (for UI changes)
  • Checked developer's documentation: Is the information available and up to date? If not, I outlined it in this pull request.
  • Checked documentation: Is the information available and up to date? If not, I created an issue at https://github.com/JabRef/user-documentation/issues or, even better, I submitted a pull request to the documentation repository.

Copy link
Contributor

github-actions bot commented Sep 24, 2024

The build for this PR is no longer available. Please visit https://builds.jabref.org/main/ for the latest build.

@calixtus
Copy link
Member

Looks good. Thanks.

@calixtus calixtus added this pull request to the merge queue Sep 24, 2024
Merged via the queue into main with commit 5ccf3e0 Sep 24, 2024
26 checks passed
@calixtus calixtus deleted the TaskProgress branch September 24, 2024 17:03
@LoayGhreeb LoayGhreeb mentioned this pull request Sep 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Strange progress
3 participants