Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[write] Add wb_set_base_font() args to write_xlsx() (#1260) #1262

Merged
merged 3 commits into from
Feb 11, 2025

Conversation

uhkeller
Copy link
Contributor

@uhkeller uhkeller commented Feb 11, 2025

  • [write] write_xlsx() now accepts wb_set_base_font() arguments and passes them on

  • [docs] Updated documentation with new parameters and example

  • [tests] Added tests for new parameters

Ulrich KELLER added 2 commits February 11, 2025 13:57
* [write] `write_xlsx()` now accepts `wb_set_base_font()` arguments and passes them on

* [docs] Updated documemtation with new paramers and example

* [tests] Added tests for new parameters
Copy link
Owner

@JanMarvin JanMarvin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks! I wouldn’t have thought of the do.call() approach, but if it works, perfectly fine for me. Could you please add a short note to the NEWS.md and add yourself to inst/AUTHORS?
I guess this could make it for release 1.13.

R/write_xlsx.R Outdated Show resolved Hide resolved
[misc] Added author

[misc] Added feature entry to `NEWS.md`

[misc] Minimal code simplification
@JanMarvin
Copy link
Owner

Thanks!

@JanMarvin JanMarvin merged commit 1423647 into JanMarvin:main Feb 11, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants